Support more than 122 simultaneous services #295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
frenchy64
force-pushed
the
tk-294-interpreted
branch
from
fc6a5c7
to
a22da80
Compare
frenchy64
changed the title
|
A simpler fix might be just to use |
|
This has been fixed upstream plumatic/plumbing#138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #294
The general approach is switch to interpreted graph compilation mode if
plumbingfails to compile the service graph witheager-compile. This way, there will not be a performance regression for graphs smaller than those described in plumatic/plumbing#138 and Trapperkeeper will gracefully choose the slower version only when plumbing's specialization strategy fails.