Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed .setAttribute() usage in scripts which conflicted with CSP 'unsafe-inline' #235

Merged
merged 1 commit into from
Jan 21, 2018
Merged

Removed .setAttribute() usage in scripts which conflicted with CSP 'unsafe-inline' #235

merged 1 commit into from
Jan 21, 2018

Conversation

IlCallo
Copy link
Contributor

@IlCallo IlCallo commented Jan 20, 2018

No description provided.

@IlCallo IlCallo changed the title master Removed .setAttribute() usage in scripts which conflicted with CSP 'unsafe-inline' Jan 20, 2018
@IlCallo
Copy link
Contributor Author

IlCallo commented Jan 20, 2018 •
edited
Loading

A README update, adding what all gulp script does, can be useful.
And I think that by ./node_modules/gulp default you meant ./node_modules/gulp/bin/gulp.js since the first points to a folder.
Actually gulp default should suffice.

Also, scss-lint is not listed as any dependency and, even when I added it manually to the package.json, it simply didn't work. I didn't needed it so I just ignored it, but someone else may need it.

@puranjayjain puranjayjain merged commit 29f967d into puranjayjain:master Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IlCallo @puranjayjain