-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse_csv: fix parsing youtube comment for newer takeout exports #79
Conversation
Thought I had a bug for a second, but turned out to be fine, so reopened! |
uh, this fix is probably fine, I just cant even visualize what that means...? Could you post/link me to example data just so I understand |
Ah, you can see the example here! https://github.com/seanbreckenridge/google_takeout_parser/pull/79/files#diff-8789098ed2a3a26eb03a72c01b6432558382e227eb4cc9bc3cbd50f570f9857bR80 Something like this: |
bleh... I don't why they just cant stick to some standard format... I guess they have to innovate™ thanks for the fix 👍 |
feel free to ping me if you want me to do a new release (though I dont think this impacts other CIs) |
Yeah, it's dynamically called anyway, so no need for new release. Thanks! |
…nd weird formatted json data in takeout see purarue/google_takeout_parser#79
…nd weird formatted json data in takeout see purarue/google_takeout_parser#79
…nd weird formatted json data in takeout see purarue/google_takeout_parser#79
noticed some errors in promnesia now that new comments started being extracted after my previous fix
of course, comments are comma-separated jsons with one like per each json 🤡 If you have any good ideas how to parse it nicer, let me know! Sadly, stdlib json parser doesn't support some sort of streaming mode :(