Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_csv: fix parsing youtube comment for newer takeout exports #79

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

karlicoss
Copy link
Contributor

@karlicoss karlicoss commented Sep 26, 2024

noticed some errors in promnesia now that new comments started being extracted after my previous fix

of course, comments are comma-separated jsons with one like per each json 🤡 If you have any good ideas how to parse it nicer, let me know! Sadly, stdlib json parser doesn't support some sort of streaming mode :(

@karlicoss karlicoss closed this Sep 27, 2024
@karlicoss karlicoss reopened this Sep 27, 2024
@karlicoss
Copy link
Contributor Author

Thought I had a bug for a second, but turned out to be fine, so reopened!

@purarue
Copy link
Owner

purarue commented Sep 27, 2024

of course, comments are comma-separated jsons with one like per each json

uh, this fix is probably fine, I just cant even visualize what that means...? Could you post/link me to example data just so I understand

@karlicoss
Copy link
Contributor Author

Ah, you can see the example here! https://github.com/seanbreckenridge/google_takeout_parser/pull/79/files#diff-8789098ed2a3a26eb03a72c01b6432558382e227eb4cc9bc3cbd50f570f9857bR80

Something like this: contentJSON='{"text":"> I am about to get buried in the concrete"},{"text":"\n"},{"text":"the most normal Veritasium video!"}'

@purarue
Copy link
Owner

purarue commented Sep 27, 2024

bleh... I don't why they just cant stick to some standard format...

I guess they have to innovate™

thanks for the fix 👍

@purarue purarue merged commit df39f16 into purarue:master Sep 27, 2024
14 checks passed
@purarue
Copy link
Owner

purarue commented Sep 27, 2024

feel free to ping me if you want me to do a new release (though I dont think this impacts other CIs)

@karlicoss
Copy link
Contributor Author

Yeah, it's dynamically called anyway, so no need for new release. Thanks!

@karlicoss karlicoss deleted the fix-youtube-comment-parsing branch September 27, 2024 23:23
karlicoss added a commit to karlicoss/promnesia that referenced this pull request Sep 29, 2024
karlicoss added a commit to karlicoss/promnesia that referenced this pull request Sep 29, 2024
karlicoss added a commit to karlicoss/promnesia that referenced this pull request Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants