Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support postprocessing of formatter output before insertion #25

Open
wyuenho opened this issue May 26, 2020 · 1 comment · May be fixed by #28
Open

Support postprocessing of formatter output before insertion #25

wyuenho opened this issue May 26, 2020 · 1 comment · May be fixed by #28

Comments

@wyuenho
Copy link
Contributor

wyuenho commented May 26, 2020

Some formatters like eslint --fix-dry-run --format json contains the formatted output in a JSON entry. Currently reformatter-replace-buffer-contents-from-file only takes the out-file and inserts directly into the original file buffer. It would be nice if we could define a postprocessor to process formatter output before insertion. Similar approaches may be used for #20 as well.

@wyuenho wyuenho changed the title Support preprocessing of formatter output before insertion Support postprocessing of formatter output before insertion May 26, 2020
wyuenho added a commit to wyuenho/reformatter.el that referenced this issue May 26, 2020
@purcell
Copy link
Owner

purcell commented Aug 14, 2020

I'm probably not going to pursue this feature request soon, but I've just landed #27, partly with eslint --fix in mind.

wyuenho added a commit to wyuenho/reformatter.el that referenced this issue Aug 29, 2020
purcell added a commit that referenced this issue Aug 30, 2020
@purcell purcell linked a pull request Aug 30, 2020 that will close this issue
purcell added a commit that referenced this issue Aug 30, 2020
wyuenho added a commit to wyuenho/reformatter.el that referenced this issue Jan 15, 2021
wyuenho added a commit to wyuenho/reformatter.el that referenced this issue Apr 27, 2021
wyuenho added a commit to wyuenho/reformatter.el that referenced this issue May 5, 2021
wyuenho added a commit to wyuenho/reformatter.el that referenced this issue May 10, 2021
wyuenho added a commit to wyuenho/reformatter.el that referenced this issue Aug 31, 2021
wyuenho added a commit to wyuenho/reformatter.el that referenced this issue Jun 23, 2022
wyuenho added a commit to wyuenho/reformatter.el that referenced this issue Jun 27, 2022
wyuenho added a commit to wyuenho/reformatter.el that referenced this issue Jun 27, 2022
wyuenho added a commit to wyuenho/reformatter.el that referenced this issue Aug 4, 2023
wyuenho added a commit to wyuenho/reformatter.el that referenced this issue Nov 23, 2023
wyuenho added a commit to wyuenho/reformatter.el that referenced this issue Nov 23, 2023
wyuenho added a commit to wyuenho/reformatter.el that referenced this issue Nov 23, 2023
wyuenho added a commit to wyuenho/reformatter.el that referenced this issue Jul 9, 2024
wyuenho added a commit to wyuenho/reformatter.el that referenced this issue Sep 3, 2024
wyuenho added a commit to wyuenho/reformatter.el that referenced this issue Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants