-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test if packages are loadable with the wrapper #170
Conversation
Yeah, upstream in nixpkgs the site-start.el looks like this: https://github.com/NixOS/nixpkgs/blob/342d73c9355613f36304a19d272d75ca86502d14/pkgs/applications/editors/emacs/site-start.el, but I'm not worried about missing any of that content, so an empty site-start.el sounds viable. |
Rebased onto master to trigger rebuilds with the latest nixpkgs. |
Is the extra |
It is only intended to enable the tree-sitter integration of the wrapper. Alternatively, the user of nix-emacs-ci could set the attribute by overriding the attribute as follows (overriding emacs.overrideAttrs (_: {
passthru.treeSitter = true;
}) To use the feature in a project like #168, either this library or the user must pay the cost. Although It's possible to handle the problem on the user side, so I will revert the commit if you don't prefer the additional complexity. |
I have removed the commit to set |
Great, thanks! |
Oh — that makes sense. |
The test which I added three years ago only builds
emacsWithPackages
wrapper with a few packages. Since then, there have been several changes made in the upstream nixpkgs repository. Unfortunately, the wrapper no longer correctly starts if it is combined with an Emacs derivation fromnix-emacs-ci
, which was not detected by the test.This PR extends the test to check if the wrapper correctly starts and loads packages.