Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI support & native compilation #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Silex
Copy link

@Silex Silex commented Jun 23, 2021

Hello,

Don't merge this it's a base for discussion.

Please tell me:

  1. That I actually mostly did it correctly (e.g the libgif part that needed to be 4 for emacs 23.4 and default for the rest)
  2. How far am I to add this lightweight/featurefull thing? As I imagine I'd add some withGui flag and conditionally set buildInput / configure flags etc, but I have trouble imagining how this option would be used externally (keep in mind I salvaged this I'm still a complete nix newbie 😆).

(native compilation is mostly done but fails, see https://github.com/purcell/nix-emacs-ci/compare/master...Silex:native-compilation?expand=1)

@Silex Silex force-pushed the master branch 2 times, most recently from 8568af3 to 8dbe69c Compare June 23, 2021 20:15
@Silex Silex force-pushed the master branch 2 times, most recently from 7c6ddd3 to a13e346 Compare April 4, 2022 11:46
@Silex Silex force-pushed the master branch 2 times, most recently from f3ee070 to f31784c Compare April 15, 2022 06:50
@Silex
Copy link
Author

Silex commented Apr 15, 2022

@purcell I'm am pretty happy with the latest changes. I disabled X for 23.4 because it needs giflib 4 and it was removed and I don't know how to build it myself.

I guess you don't want to merge this because it'd include X in most of your images, but if point me to how to make it so I can do something like WITH_X=1 nix-env -iA emacs-26-3 then I can do the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant