Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8: Update LoggerTests #9

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix #8: Update LoggerTests #9

wants to merge 4 commits into from

Commits on Feb 9, 2023

  1. Fix: purduesigbots#8 Make LoggerTests work cross-platform 

    The previous tests used a technically write-only stream in memory, which causes the tests to fail on some systems. Instead, we can use an `fmemopen` stream to ensure it is always readable.
    @NoRePercussions
    NoRePercussions committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    c06cbcc View commit details
    Browse the repository at this point in the history

  2. Fix: Add checks that logger files don't have more contents 

    If each logger test writes more levels than requested as-is, the tests would not catch it due to the logging order. This way, we can assert that it does not write more.
    @NoRePercussions
    NoRePercussions committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    271a9da View commit details
    Browse the repository at this point in the history

  3. Fix: Make TestLazyLogging actually check logging 

    In its previous form, TestLazyLogging checked that logging didn't error and that the lambda used was scoped. This version will check that it logs the contents given and no more.
    @NoRePercussions
    NoRePercussions committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    2485e22 View commit details
    Browse the repository at this point in the history

  4. Fix leaked memory in tests

    @NoRePercussions
    NoRePercussions committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    2c85254 View commit details
    Browse the repository at this point in the history