-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Added port to project.pros: #292
Conversation
…sal-dependency-error 🐛 Fix macos CI universal dependency errors
Co-authored-by: BennyBot <48661356+BennyBot@users.noreply.github.com>
Co-authored-by: BennyBot <48661356+BennyBot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Update main.yml * Try new version of python * Maybe this will work? * We try again * Make the uninstall work * Work --------- Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer we test this and provide screenshots if possible. I know the change is small but I don't want any small edge cases getting through
Co-authored-by: BennyBot <48661356+BennyBot@users.noreply.github.com>
Co-authored-by: BennyBot <48661356+BennyBot@users.noreply.github.com>
I just rebased it so that it had the up to date main.yml file so that it would pass CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on mac. LGTM
Summary:
This pr adds the port option to project.pros
Motivation:
#223