Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Added port to project.pros: #292

Merged
merged 13 commits into from
Sep 29, 2023
Merged

✨ Added port to project.pros: #292

merged 13 commits into from
Sep 29, 2023

Conversation

Aniket-Rai1
Copy link
Contributor

@Aniket-Rai1 Aniket-Rai1 commented Jun 3, 2023

Summary:

This pr adds the port option to project.pros

Motivation:

#223

@Aniket-Rai1 Aniket-Rai1 changed the title Feature/port ✨ Added port to project.pros: Jun 3, 2023
pros/cli/conductor.py Outdated Show resolved Hide resolved
Co-authored-by: BennyBot <48661356+BennyBot@users.noreply.github.com>
.github/workflows/main.yml Outdated Show resolved Hide resolved
Co-authored-by: BennyBot <48661356+BennyBot@users.noreply.github.com>
pros/cli/upload.py Outdated Show resolved Hide resolved
Copy link
Member

@BennyBot BennyBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Update main.yml

* Try new version of python

* Maybe this will work?

* We try again

* Make the uninstall work

* Work

---------

Co-authored-by: Kunwar Sahni <kunwar.sahni01@gmail.com>
Copy link
Member

@ayushuk ayushuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer we test this and provide screenshots if possible. I know the change is small but I don't want any small edge cases getting through

@BennyBot
Copy link
Member

BennyBot commented Jun 5, 2023

I just rebased it so that it had the up to date main.yml file so that it would pass CI.

Copy link
Member

@ayushuk ayushuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on mac. LGTM

@ayushuk ayushuk merged commit 149562b into develop Sep 29, 2023
@ayushuk ayushuk deleted the feature/port branch September 29, 2023 00:11
This was referenced Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants