Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Filename validator for new projects #298

Merged
merged 6 commits into from
Feb 18, 2024

Conversation

12944qwerty
Copy link
Member

No description provided.

Copy link
Member

@ayushuk ayushuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets add those extra characters we talked about

@ayushuk ayushuk added the in progress This is currently being worked on label Jan 22, 2024
@12944qwerty 12944qwerty changed the title 🚸 use regex for file validator instead 🚸 use better file validator instead Jan 24, 2024
@ayushuk ayushuk changed the title 🚸 use better file validator instead 🚸 Filename validator for new projects Jan 24, 2024
@ayushuk
Copy link
Member

ayushuk commented Jan 30, 2024

I'm still able to make projects with an emoji in the name which will break on the brain. Another TODO we need to add to this task is to see if the brain supports non-ascii characters in the project name (especially the characters that are not in the english alphabet).
Screenshot 2024-01-30 at 11 50 40 AM

@ayushuk ayushuk merged commit a335b80 into develop Feb 18, 2024
10 checks passed
@ayushuk ayushuk deleted the enhancement/better-file-validator branch February 18, 2024 17:21
@ayushuk ayushuk mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress This is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants