Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simplified Chinese and Korean sans-serif fallback problem #6

Merged
merged 1 commit into from
Nov 11, 2019

Conversation

fy-meng
Copy link

@fy-meng fy-meng commented Sep 1, 2019

Hi, I've noticed that room labels are rendered in serif instead of the desired sans-serif if language is set to simplified Chinese or Korean on some os/browser (surprisingly Japanese is rendered correctly; normally if one of these goes wrong then all of them goes wrong).

As in other languages, serif fonts in Chinese are rather hard to read on digital screens, and is especially annoying when put in small clustered labels like in r6maps.

I made a small modification to ensure that Chinese and Korean characters are rendered in Noto Sans, a free cross-language sans-serif font.

Before the fix:
before

After the fix:
after

Sans-serif example in Chinese, easier to read on screen
sans-serif

Serif example in Chinese, easier to read on printed paper
serif

@purechaose purechaose merged commit 8dc56ce into purechaose:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants