[Devtooling-1063] Logging when max retries hit #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fergalmcl
requested review from
HemanthDogiparthi12,
carnellj-genesys,
charliecon and
dginty4
as code owners
There was a problem hiding this comment.
I think you have to log the error when the sdk is sleeping until the retry-after is reached. and retrying again .
look at this piece of code in apiclient.
private boolean waitBeforeRetry(long retryAfterMs){}
Adding a log here, solves the purpose of this ticket and gives more visibility to the user that SDK is in retry process.
"message":"Rate limit encountered. Retry the request in [retryAfterMs] seconds"
HemanthDogiparthi12
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.