Make the tests actually do some debugging #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
puremourning
commented
Jun 1, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 12 files reviewed, 1 unresolved discussion
compiler/vimspector_test.vim, line 2 at r1 (raw file):
" vimspector - A multi-language debugging system for Vim " Copyright 2018 Ben Jackson
2019
puremourning
force-pushed
the
breakpoint-test-stepping
branch
from
836ec62 to
2dec93d
Compare
puremourning
force-pushed
the
breakpoint-test-stepping
branch
from
3ebfe15 to
f4c971a
Compare
puremourning
commented
Jun 8, 2019
There was a problem hiding this comment.
Reviewed 10 of 12 files at r1, 9 of 9 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually fire up the debugger and make a step. Prove that the PC gets updated correctly and the current line/col are also updated.
This involved pulling in more of vim's test code, so that was all moved into a
tests/libdirectory