Fix: Remove balloon '...' in windows != code_window #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Problem: In non-code window, user see a '...' balloon even if python knows it does not need to work Solution: use pyeval in vim so that python's knowledge is getting back from the stack as return value
tinmarino
force-pushed
the
merge_ballon
branch
from
7f39efc to
1e15391
Compare
puremourning
approved these changes
Jan 10, 2020
There was a problem hiding this comment.
Thanks for the PR!
I will check the CI failure later probably a flake.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
puremourning
approved these changes
Jan 10, 2020
There was a problem hiding this comment.
Reviewable status:
|
Thanks for sending a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the ... balloon in non code windows
Problem: In non-code window, user see a '...' balloon even if python knows it does not need to work
Solution: use
pyevalin vim so that python's knowledge is getting back from the stack as return value