Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update library to Contributors library standards #121

Merged
merged 3 commits into from
Oct 8, 2020
Merged

Update library to Contributors library standards #121

merged 3 commits into from
Oct 8, 2020

Conversation

maxdeviant
Copy link
Member

This PR updates purescript-css to adhere to the Contributors library guidelines.

This is part of the purescript-contrib/governance#13 effort.

maxdeviant
maxdeviant commented Oct 8, 2020
View reviewed changes
bower.json Outdated
@@ -11,7 +11,7 @@
"license": "Apache-2.0",
"repository": {
"type": "git",
"url": "git://github.com/slamdata/purescript-css.git"
"url": "https://github.com/purescript-contrib/purescript-css.git"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The registry needs to be updated with the new URL. There's an open PR for this: purescript/registry#81.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on the registry, but I believe we’re preserving the original repository locations and following redirects. So with that in mind we only need to change this to https

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, reverted to match the URL in the registry.

@maxdeviant
Copy link
Member Author

Verified that spago build and spago test work as expected:

λ spago build
[info] Installation complete.
[info] Build succeeded.
λ spago test
[info] Installation complete.
[info] Build succeeded.
[info] Tests succeeded.

@thomashoneyman thomashoneyman merged commit 851327d into purescript-contrib:main Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxdeviant @thomashoneyman