Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for calc expressions. Addresses #55. #140

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Support for calc expressions. Addresses #55. #140

merged 1 commit into from
Feb 2, 2022

Conversation

nsaunders
Copy link
Member

Description of the change
This change adds support for calc expressions (see #55). This is pretty much a direct port from Clay, which appears to be the original basis for this library. In the process of implementing this feature, I've also aligned the size data types with Clay, which is obviously a significant breaking change but hopefully a worthwhile one...

For reference, here are the relevant modules in Clay for comparison:

  1. src/Size.hs
  2. src/Border.hs
  3. src/Gradient.hs
  4. src/Media.hs

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory Given that the README is pretty empty already, I'm not sure what I should say about this feature...suggestions welcome!
  • Added a test for the contribution (if applicable)

@jamesdbrock
Copy link
Member

Thanks for this PR!

@jamesdbrock
Copy link
Member

I don't know anything about this library and I'm interested in your comment that Clay appears to be the original basis for this library. If that's true then I think we should add that information to the README for the library, to provide a reference point for new users.

Copy link
Contributor

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you!

@thomashoneyman thomashoneyman added purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 status: accepted This issue is now ready to be implemented via a PR. labels Jan 21, 2022
@thomashoneyman
Copy link
Contributor

@nsaunders We're looking for maintainers to help with purescript-css (reviewing PRs and/or contributing). This is a great PR -- would you be interested in being added as a collaborator to this repository?

@nsaunders
Copy link
Member Author

@thomashoneyman thanks for the comment... I'm glad I was able to provide some value here and would be happy to help out more in the future. 👍

@thomashoneyman
Copy link
Contributor

Great! I've added you as a collaborator to this repository with maintainer's access. (cc: @jamesdbrock)

@nsaunders nsaunders merged commit 2e38830 into purescript-contrib:main Feb 2, 2022
@nsaunders nsaunders mentioned this pull request Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 status: accepted This issue is now ready to be implemented via a PR.
Development

Successfully merging this pull request may close these issues.

3 participants