Refactor FontStyle type #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good 👍 unfortunately this and every other PR you open are conflicting after merging the selector fixes. |
|
no problem let's merge them one by one, I'll rebase after each merge :) |
|
Sounds good! Looking back on them all, I only have those couple of minor comments I made... but also some of the enumerable additions could be reworked in the same style as this now, if you don't mind? |
* Make it a sum-type rather than newtype * Extract FontStyle to separate module * Add some tests for main use-cases
vyorkin
force-pushed
the
feature/font-style-type
branch
from
5a1cf3f
to
33c790f
Compare
|
Rebased, should be ready to merge. Sure, I'll update other PR's to use sum types like we did here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FontStyle-related things into a separate moduleResolves #69