Skip to content

Bug (minor): img element does not take children #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasonzoladz opened this issue Apr 27, 2016 · 3 comments
Closed

Bug (minor): img element does not take children #76

jasonzoladz opened this issue Apr 27, 2016 · 3 comments
Labels
type: breaking change A change that requires a major version bump.

Comments

@jasonzoladz
Copy link

jasonzoladz commented Apr 27, 2016

Currently, using img shows this in the console:

image

It still works, but nobody likes seeing red in development.

The type signature for img should just be:

img :: Array Props -> ReactElement

Let me know if you'd like me submit a pull request and I'll put one together this weekend.

@jasonzoladz
Copy link
Author

This applies to hr tags as well.

@ethul
Copy link
Contributor

ethul commented Apr 28, 2016

Thanks for pointing this out. Does this also apply to input and link? There might be others too.

Since this is a breaking change, perhaps we can hang on to this one and bring in such changes at the point when have other breaking changes to make. To try to get them all in at once.

Sound okay?

@ethul ethul added the type: breaking change A change that requires a major version bump. label Apr 28, 2016
@jasonzoladz
Copy link
Author

Sounds good.

ethul added a commit that referenced this issue Apr 18, 2018
ethul added a commit that referenced this issue Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking change A change that requires a major version bump.
Development

No branches or pull requests

2 participants