Add the SVG x and y attributes
#113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Thanks for the addition. Regarding having a separate module for SVG props, my opinion is that it is okay all in one module unless we run into a case were we have an attribute with the same name as another attribute, but with a different type. @paf31 do you have a preference on this? |
|
Yeah that seems fine to me. It'd be nicer to use rows really, but we're not going to be able to do that easily. |
|
Sounds good. Thanks @paf31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #112. It adds the SVG x and y attributes.
I wasn't sure if I should create a
React.DOM.SVG.Propsmodule instead.