Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run slowest tests last and print status updates #72

Merged
merged 2 commits into from
May 24, 2021

Conversation

milesfrain
Copy link
Member

@milesfrain milesfrain commented May 12, 2021

Description of the change

When I first ran tests locally in this repo, my system stalled for a minute at 100% CPU, which made me think something was wrong. Not sure if this is a real problem, or if parsing is just really slow for the stack overflow tests.

This PR moves the slower stack overflow tests to the end of each suite and prints some status messages to users.

time spago test                                                       

Compiling Test.Main
           Src   Lib   All
Warnings   0     0     0  
Errors     0     0     0  
[info] Build succeeded.
Testing CodePoint parsing

Running basic tests
Running overflow tests (may take a while)


Testing CodeUnit parsing

Running basic tests
Running overflow tests (may take a while)
[info] Tests succeeded.

spago test  122.84s user 1.35s system 102% cpu 2:01.65 total

Also, wondering if we should configure actions to ignore readme files so updating the changlog doesn't unnecessarily re-trigger CI.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username

@milesfrain milesfrain changed the title Move slow tests to end and print status updates Run slowest tests last and print status updates May 12, 2021
## [v6.0.1](https://github.com/purescript-contrib/purescript-string-parsers/releases/tag/v6.0.1) - 2021-05-11

Other improvements:
- Fix transitive dependencies errors found by Spago 0.20 (#71 by @milesfrain)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think it's necessary to name authors in the changelog.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't actually read the contrib template carefully enough in this case. Seems like there's a mismatch between core (no username) and contrib (with username).

I think no-username is easier.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We didn't used to associate any usernames with pull requests, but we'd like to going forward (for core, contrib, etc.). However, it is optional if you'd rather not have your username added.

@thomashoneyman
Copy link
Contributor

I think it's a great idea to ignore readme files for actions.

@thomashoneyman thomashoneyman merged commit 18a580c into purescript-contrib:main May 24, 2021
@milesfrain milesfrain deleted the reorder-tests branch May 25, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants