Skip to content

Import Data.Generic.Rep from prelude #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kl0tl
Copy link
Contributor

@kl0tl kl0tl commented Dec 28, 2020

Description of the change
We merged generics-rep into prelude and renamed the Data.Generic.Rep.* modules to Data.*.Generic in purescript/purescript-prelude#235.

Should we mention the removal of generics-rep from the dependencies in the changelog?

@kl0tl
Copy link
Contributor Author

kl0tl commented Dec 28, 2020

The build fails because some packages depend on generics-rep in the package set but it compiles with the rc5 branch of my fork and purescript-contrib/purescript-profunctor-lenses#123:

let upstream =
      https://raw.githubusercontent.com/kl0tl/package-sets/rc5/src/packages.dhall

in  upstream
  with profunctor-lenses =
        upstream.profunctor-lenses
       { repo = "https://github.com/kl0tl/purescript-profunctor-lenses.git"
        , version = "fix-Data.Lens.Zoom.zoom"
        }

@thomashoneyman
Copy link
Contributor

We should mention the change, as part of the 0.14 updates, but that can be done when we walk through to add release notes for all these libraries.

@thomashoneyman thomashoneyman merged commit fedc18d into purescript-contrib:main Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants