This repository was archived by the owner on Oct 4, 2020. It is now read-only.
Update tests for 0.7 and fix bug in JS code #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. If you modify the build to pull in |
|
@paf31: Thank you. I included test-src in the gulpfile and removed the |
paf31
added a commit
that referenced
this pull request
Jun 11, 2015
Update tests for 0.7 and fix bug in JS code
|
👍 Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By updating the test-code to purescript 0.7, I got all tests compiling and passing. I'm not sure about some of the changes, so I would appreciate if someone could review this. In particular, I'm not sure about the
Arbitraryinstances forList awhich I included in both Map.purs and StrMap.purs.I also added a missing
functionkeyword in theStrMap.jsJavaScript code.