Skip to content
This repository was archived by the owner on Aug 4, 2023. It is now read-only.

Remove exists since underlying Async.exists was removed #36

Conversation

sigma-andex
Copy link
Contributor

Description of the change

Update for purescript-node/purescript-node-fs#61


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@sigma-andex sigma-andex mentioned this pull request Apr 13, 2022
4 tasks
@JordanMartinez
Copy link
Contributor

🏓 @thomashoneyman

@thomashoneyman
Copy link
Contributor

I’m not sure we can just replace the asynchronous exists with a liftAff over the synchronous one — @natefaubion, do you have any opinion on that?

Since you can call liftAff on any of these functions that run synchronously in Effect, I don’t think they need to be explicitly ported over to this library. Why not just remove this function altogether?

@natefaubion
Copy link
Contributor

I agree with @thomashoneyman. Exporting this as Aff seems like a footgun.

@sigma-andex sigma-andex changed the title Use underlying Sync.exists since Async.exists was removed Remove exists since underlying Async.exists was removed Apr 14, 2022
@sigma-andex
Copy link
Contributor Author

Ok I removed it again.

@JordanMartinez
Copy link
Contributor

@sigma-andex Sorry about misleading you. I was focusing too much on preventing unneeded breakage rather than the other considerations Thomas brought up.

@thomashoneyman Looks like this PR is ready to be approved now.

@sigma-andex
Copy link
Contributor Author

@sigma-andex Sorry about misleading you. I was focusing too much on preventing unneeded breakage rather than the other considerations Thomas brought up.

No worries!

@JordanMartinez JordanMartinez merged commit 0c46f0c into purescript-deprecated:master Apr 14, 2022
@sigma-andex sigma-andex deleted the update-for-fs-async-exists branch April 21, 2022 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants