Update for PureScript 0.14 #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomashoneyman
commented
May 5, 2021
src/Halogen/VDom/StringRenderer.purs
Outdated
| @@ -47,7 +47,7 @@ render getTagType renderAttrs renderWidget = go | |||
| as = renderAttrs attrs | |||
| as' = maybe as (\(Namespace ns) -> "xmlns=\"" <> escape ns <> "\"" <> if S.null as then "" else " " <> as) maybeNamespace | |||
| in | |||
| "<" <> name <> (if S.null as then "" else " ") <> as <> | |||
| "<" <> name <> (if S.null as then "" else " ") <> as' <> | |||
There was a problem hiding this comment.
as' was previously unused -- presumably it was supposed to be used here?
|
Changes look good to me! Should we switch this to GH actions too? Especially since Travis seems to have done something weird with these builds. |
…attributes. (#11) Due to a mixup with primed and non-primed variable names (`as` and `as'`), if you have an element with a namespace but no attributes, such as `SVG.g [] [ ... ]` it was rendering as: `<gxmlns="..."`. This commit fixes that behaviour. Co-authored-by: Kris Jenkins <kjenkins@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.