stat can result in unexpected runtime failures

[Thimoteus]

This is a failing example that's close to what I was using.

I'm not sure if the problem is with stat or catchException, but essentially this is the problem:

You can use catchException to discharge an EXCEPTION assumption from your program. Great! If we use enough catchExceptions, the compiler tells us (assuming everything was well-typed) that our program won't have any uncaught exceptions at runtime.

Except it does. catchException doesn't ... catch the exception ... when using stat on a path that doesn't exist.

This threw me for a loop since I was assuming that uncaught runtime exceptions wouldn't happen.

[hdgarrood]

😱 this definitely shouldn't happen.

Perhaps we incorrectly assumed the error would be thrown immediately if fs.statSync failed? I'm not at my laptop right now but does it work in node using JS directly if you try to wrap fs.statSync in a try...catch block?

[Thimoteus]

It seems to work as intended in node:

> try {
... fs.statSync('./something');
... } catch (e) {
... console.log(e);
... }
{ [Error: ENOENT: no such file or directory, stat './something']
  errno: -2,
  code: 'ENOENT',
  syscall: 'stat',
  path: './something' }

[hdgarrood]

Fixed by b1a99f8, released in 0.9.3. Thanks for the report! :)

[hdgarrood]

Oops, I meant v0.10.1. I really need to get on and implement pulp version to protect me from myself.