Update to PureScript v0.15.0 #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanMartinez
suggested changes
Mar 22, 2022
|
CI is failing due to unused imports. |
src/Node/FS/Async.purs
Outdated
| foreign import open_ :: Fn4 FilePath String (Nullable FileMode) (JSCallback FileDescriptor) Unit | ||
| foreign import read_ :: Fn6 FileDescriptor Buffer BufferOffset BufferLength (Nullable FilePosition) (JSCallback ByteCount) Unit | ||
| foreign import write_ :: Fn6 FileDescriptor Buffer BufferOffset BufferLength (Nullable FilePosition) (JSCallback ByteCount) Unit | ||
| foreign import close_ :: Fn2 FileDescriptor (JSCallback Unit) Unit |
There was a problem hiding this comment.
We can keep this as-is, but typically we'd name this
foreign import closeImpl :: ...where *Impl denotes an FFI implementation
There was a problem hiding this comment.
Admittedly, this library already diverged from our typical best practices with this big fs record 😆
thomashoneyman
approved these changes
Mar 23, 2022
JordanMartinez
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Backlinking to purescript/purescript#4244
Migrates FFI to ES modules
Checklist: