-
Notifications
You must be signed in to change notification settings - Fork 25
Add support for connection
#25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
type: enhancement
A new feature or addition.
Comments
Sounds good to me. I guess we don’t yet have bindings for net.Server either? |
Thanks! |
I invited you to be an admin of the org a while back actually, did that ever come through? |
Yeah, I accepted that as well (I'm just slow 😊). Thanks! |
Fixed by #49. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The node.js
http
module has had support forrequest.connection
for ages (since version 0.3.0), it's just been poorly documented. Up until the 8.x series it was tucked away in the comment of the'connection'
event. Since then, it's had its own documentation. I'd like to propose we add support forconnection
, but it will require some work for theSocket
it returns.My guess (and what I mentioned on slack) is that we'll want a
purescript-node/purescript-node-net
package, where we haveSocket
and all its facilities defined. If that's the case, I'm more than happy to do the work if someone can make the repo. Then, we can exposeconnection :: Node.HTTP.Request -> Node.Net.Socket
. Does that sound about right?The text was updated successfully, but these errors were encountered: