Skip to content

Add support for connection #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joneshf opened this issue Apr 26, 2019 · 6 comments
Closed

Add support for connection #25

joneshf opened this issue Apr 26, 2019 · 6 comments
Labels
type: enhancement A new feature or addition.

Comments

@joneshf
Copy link

joneshf commented Apr 26, 2019

The node.js http module has had support for request.connection for ages (since version 0.3.0), it's just been poorly documented. Up until the 8.x series it was tucked away in the comment of the 'connection' event. Since then, it's had its own documentation. I'd like to propose we add support for connection, but it will require some work for the Socket it returns.

My guess (and what I mentioned on slack) is that we'll want a purescript-node/purescript-node-net package, where we have Socket and all its facilities defined. If that's the case, I'm more than happy to do the work if someone can make the repo. Then, we can expose connection :: Node.HTTP.Request -> Node.Net.Socket. Does that sound about right?

@hdgarrood
Copy link
Member

Sounds good to me. I guess we don’t yet have bindings for net.Server either?

@hdgarrood
Copy link
Member

@joneshf
Copy link
Author

joneshf commented May 7, 2019

Thanks!

@garyb
Copy link
Member

garyb commented May 7, 2019

I invited you to be an admin of the org a while back actually, did that ever come through?

@joneshf
Copy link
Author

joneshf commented May 7, 2019

Yeah, I accepted that as well (I'm just slow 😊). Thanks!

@JordanMartinez JordanMartinez added the type: enhancement A new feature or addition. label Dec 7, 2021
@JordanMartinez
Copy link
Contributor

Fixed by #49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A new feature or addition.
Projects
None yet
Development

No branches or pull requests

4 participants