Skip to content

feat(#28): add support for server.address() #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

srghma
Copy link

@srghma srghma commented Apr 23, 2020

No description provided.

@srghma
Copy link
Author

srghma commented Jun 3, 2020

@garyb @hdgarrood ping...

@srghma
Copy link
Author

srghma commented Jun 11, 2020

I dont want to be pesky, but this pr is an exact copy of a function from https://github.com/purescript-node/purescript-node-net/blob/1fd91c872ecff202ae86b848f2c8d054f7a751f3/src/Node/Net/Server.purs#L72-L88

I hope this simplifies review, I have already tested it in my fork of hyper purescript-hyper/hyper#94

@srghma
Copy link
Author

srghma commented Feb 3, 2021

@hdgarrood updated

but it's also possible to implement this without duplicating the code

... -- export address from here and Address from Net

address = unsafeCoerce Net.adress

but Server is different, so it's better to duplicate the code

@hdgarrood
Copy link
Member

Thanks, we will try to get to this after v0.14.0 is released.

@jamesdbrock
Copy link
Member

This PR looks good to me.

@JordanMartinez
Copy link
Contributor

Superceded by #49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants