Skip to content

Fix lockup text not being ellipsed in some flex contexts #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2020
Merged

Fix lockup text not being ellipsed in some flex contexts #151

merged 1 commit into from
May 22, 2020

Conversation

arthurxavierx
Copy link
Contributor

No description provided.

@arthurxavierx arthurxavierx self-assigned this May 21, 2020
@hdgarrood
Copy link
Contributor

This seems ok to me, but it feels like it might risk triggering one of the iOS flex bugs we saw recently, where things shrink right down to their min-width. I can't remember whether you have an iOS device to test on; I could take a look if you'd like.

@arthurxavierx
Copy link
Contributor Author

Oh, I hadn't heard of that bug yet. Yeah, that sounds risky. Unfortunately I don't have access to an iOS device. Could you help me with testing, please?

@arthurxavierx arthurxavierx merged commit 217261a into master May 22, 2020
@arthurxavierx arthurxavierx deleted the arthur/fix/lockup-ellipsis branch May 22, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddie927 maddie927 maddie927 approved these changes

@hdgarrood hdgarrood Awaiting requested review from hdgarrood

Assignees

@arthurxavierx arthurxavierx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arthurxavierx @hdgarrood @maddie927