Skip to content

add maybeForm component #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

add maybeForm component #158

wants to merge 2 commits into from

Conversation

tippenein
Copy link
Contributor

similar to array but adds an optional value

c/o @arthurxavierx

similar to `array` but adds an optional value
@arthurxavierx
Copy link
Contributor

arthurxavierx commented Jun 8, 2020

You need to add maybeForm to the exports list of this module. And while you're at it, could you please change line 84 to this?

import Lumi.Components.Form.Internal (Forest, FormBuilder', FormBuilder, SeqFormBuilder', SeqFormBuilder, Tree(..), formBuilder, formBuilder_, invalidate, listen, parallel, revalidate, sequential) as Internal

In #153 I've meant to expose the constructors of Tree from Lumi.Components.Form but I've confused it with Forest (which is a type synonym and doesn't have constructors).


Actually maybe it's a better idea to remove that huge exports list and just add module Lumi.Components.Form to it?

@hdgarrood
Copy link
Contributor

Could you add a use of maybeForm in one of the examples please? That way we can test it outside of any particular app.

@tippenein
Copy link
Contributor Author

I'm not quite sure if this is worth it. I won't be able to use it because of requirements changing and.. they don't make sense for putting in a library. If we want this in here anyway we can merge it but I can't use it

@tippenein tippenein closed this Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants