Some improvements to the Upload component #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdgarrood
reviewed
Jun 19, 2020
arthurxavierx
force-pushed
the
arthur/upload-improvements
branch
from
f4f9293 to
7de59a3
Compare
kimispencer
approved these changes
Jun 19, 2020
arthurxavierx
force-pushed
the
arthur/upload-improvements
branch
2 times, most recently
from
43483b2 to
f113b34
Compare
arthurxavierx
force-pushed
the
arthur/upload-improvements
branch
from
f113b34 to
d679eae
Compare
|
@kimispencer @spicydonuts I've updated this PR with some feedback from @hdgarrood. Could you review it again, please? |
maddie927
approved these changes
Jun 22, 2020
codedmart
reviewed
Jun 23, 2020
src/Lumi/Components/Upload.purs
Outdated
| @@ -124,6 +126,8 @@ type UploadProps = | |||
|
|
|||
| type UploadBackend = | |||
| { fetch :: FileId -> Aff FileInfo | |||
| -- | Allows for running arbitrary | |||
There was a problem hiding this comment.
Is there suppose to be more to this comment? As is it doesn't seem that useful.
There was a problem hiding this comment.
Oh yes, thanks for catching that!
codedmart
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains breaking changes.
Remove theonChangeprop fromUploadand replace it withonUpload :: Array FileId -> Effect UnitandonRemove :: FileId -> Maybe (Effect Unit).TheMaybeinonRemovelets us make some files non-removable.readonly :: Booleanfield toFileInfothat indicates whether a given file may be removed or not.remove :: FileId -> Aff Booleanfield toUploadBackendthat allows for running an async action to check whether the file should be removed (e.g. a confirmation modal).onClick :: FileId -> Maybe (Effect Unit)prop toUploadso that users can interact with the uploaded files — e.g. for downloading them.FormDefaultsinstances forSetandMap.