Data fields should be added

[immae]

All html attributes support arbitrary attributes like "data-key", which are not currently in the SharedProps type. Would it be possible to add them, for instance as a data :: Object String which would translate to data-key = "values" attributes?

[tesujimath]

Are you aware that you can work around this limitation, like this?

element (unsafeCreateDOMComponent "button")
      { className: "navbar-toggler"
      , type: "button"
      , "data-toggle": "collapse"
      , "data-target": "#navbarSupportedContent"
      , "aria-controls": "navbarSupportedContent"
      , "aria-expanded": "false"
      , "aria-label": "Toggle navigation"
      , children: [ R.span { className: "navbar-toggler-icon" } ]
      }

[immae]

Ah, no I’m still a beginner in purescript, thanks for the hint.

Though it may be good to have a mechanism for that kind of keys to avoid being obliged to use a workaround

[tesujimath]

@immae I don't disagree with that point ;-)

[maddie927]

This might be possible, I'll give it a try

[i-am-the-slime]

I'm trying to use react-testing-library and it works, but the workaround is pretty painful. If at least there was support for data-testid it would help me greatly :)

[i-am-the-slime]

@spicydonuts Did you get around to this? Could you give an outline of your idea so that I or somebody else might try?

[maddie927]

What do you think of this approach? I used _data :: Object String instead of data, as some elements already have a data attribute.

R.div { _data: fromHomogeneous { hmm: "something" } }

<div data-hmm="something"></div>

[immae]

@spicydonuts : this looks good, thanks for the work!

[i-am-the-slime]

Nice, nice, nice, it works perfectly!

How about taking a homogenous Record right away so it looks a bit prettier at use site? Also maybe "data-" as the name? I'm not sure about this one because of the quotes, but I like that it's the exact prefix.

[maddie927]

The problem with taking records directly is the extra type variable for the fields. If you don't supply a record (all the fields are optional) the compiler can't infer what the type is supposed to be, which is an error. If we could tell the compiler it's fine to default to an empty record it would work..

Yeah, I thought about that. The quotes seemed kind of annoying, but it is nice that it reads like the end result. Also I already released it so it's probably not worth it to change it 😅