Remove using PureScript internals in JavaScript #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keijokapp
force-pushed
the
7-remove-using-ps-internals
branch
from
bf9f5dc to
53d4709
Compare
garyb
approved these changes
Jan 8, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7
Seems like specifying scroll behavior was always broken. And it wasn't even passed to the DOM API in case of
scrollIntoView. I also added missing"instant"scroll behavior option. And Spago files to make local development easier.Not sure if that's the best way to do it. Seems like a lot of boilerplate and some healthy amount of duplication. In these cases, the data structures (
ScrollToOptionsandScrollIntoViewOptions) are simple and all values have static defaults (I presumetopandleftdefault to0.0) so we don't need to use null values. But I don't know how this approach would work in more complicated use cases.