Skip to content

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Fixes #8. I haven't added support for the signal option because that means this lib needs to depend on web-fetch, and I'm not sure how that affects the dependencies.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez added the purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 label Mar 23, 2022
This change wasn't breaking until this commit
@garyb
Copy link
Member

garyb commented Mar 23, 2022

I think it would be nice to expose the version without options still.

@JordanMartinez
Copy link
Contributor Author

@garyb Meaning, we keep addEventListener as is (which reduces breakage) and define something like addEventListener'?

@garyb
Copy link
Member

garyb commented Mar 25, 2022

Yeah exactly. Perhaps addEventListenerWithOptions for the name... I'm fine with primes personally, but I know some people prefer words 😄

@JordanMartinez
Copy link
Contributor Author

Done.

@JordanMartinez JordanMartinez merged commit 5470e50 into purescript-web:master Mar 25, 2022
@JordanMartinez JordanMartinez deleted the fix-event-listeners branch March 25, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support addEventListener options param
3 participants