You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Similar to #12 and I think further motivating #14: I'm wanting to use fetch in a Node setting and would like to pass a Buffer (from purescript-node-buffer) as the request body. I could make a PR to do so, but understandable if you'd prefer to avoid any node-* dependencies until this is migrated from web-fetch → js-fetch.
The text was updated successfully, but these errors were encountered:
I don't think this library should have node specific dependencies regardless. The point of moving to js-fetch is that it's portable between both environments. If you introduce a node specific dependency (ie, node:buffer), it's no longer portable. I think that a hypothetical fromBuffer should be in a node-fetch library.
That makes sense. Really I'm trying to use this via the higher-level purescript-fetch library, so probably node-fetch could wrap that, and both this library and purescript-fetch could remain portable.
Similar to #12 and I think further motivating #14: I'm wanting to use
fetch
in a Node setting and would like to pass aBuffer
(frompurescript-node-buffer
) as the request body. I could make a PR to do so, but understandable if you'd prefer to avoid anynode-*
dependencies until this is migrated fromweb-fetch
→js-fetch
.The text was updated successfully, but these errors were encountered: