Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to v0.14.0-rc3 #13

Closed
wants to merge 5 commits into from
Closed

Update to v0.14.0-rc3 #13

wants to merge 5 commits into from

Conversation

JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Dec 8, 2020 •
edited
Loading

@JordanMartinez
Copy link
Contributor Author

CI fails with this error:

> eslint src && spago build '--censor-lib --strict'


/home/runner/work/purescript-web-file/purescript-web-file/src/Web/File/FileReader.js
Error:   1:11  error  'FileReader' is already defined as a built-in global variable  no-redeclare

✖ 1 problem (1 error, 0 warnings)

kl0tl
kl0tl previously approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@kl0tl kl0tl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happens because of the /* global FileReader */ comment in src/Web/File/FileReader.js, we can remove it.

@kl0tl kl0tl dismissed their stale review December 8, 2020 22:28

Shouldn’t we also upgrade the bower dependencies to master?

kl0tl
kl0tl reviewed Dec 8, 2020
View reviewed changes
spago.dhall
Comment on lines +1 to +4
{-
Welcome to a Spago project!
You can edit this file as you like.
-}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we remove this comment?

thomashoneyman
thomashoneyman requested changes Dec 9, 2020
View reviewed changes
.github/workflows/ci.yml
@@ -1,6 +1,6 @@
name: CI

on: push
on: [push, pull_request]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on: [push, pull_request]
on:
push:
branches: [master]
pull_request:
branches: [master]

@thomashoneyman
Copy link
Contributor

We also need to update the Bower file to point to master.

@JordanMartinez JordanMartinez deleted the updateTo14 branch December 10, 2020 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kl0tl kl0tl kl0tl left review comments

@thomashoneyman thomashoneyman thomashoneyman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JordanMartinez @thomashoneyman @kl0tl