Skip to content

getBoundingClientRect should be an Element API #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
natefaubion opened this issue Feb 22, 2019 · 5 comments
Closed

getBoundingClientRect should be an Element API #10

natefaubion opened this issue Feb 22, 2019 · 5 comments
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.

Comments

@natefaubion
Copy link

https://developer.mozilla.org/en-US/docs/Web/API/Element/getBoundingClientRect
@natefaubion
Copy link
Author

I hit this issue because I need to measure an SVGElement.

@thomashoneyman thomashoneyman added the purs-0.14 A reminder to address this issue or merge this PR before we release PureScript v0.14.0 label Dec 10, 2020
@thomashoneyman
Copy link
Contributor

I think this is reasonable to address as part of the 0.14 updates.

@thomashoneyman thomashoneyman mentioned this issue Dec 10, 2020
Closed
@thomashoneyman thomashoneyman removed the purs-0.14 A reminder to address this issue or merge this PR before we release PureScript v0.14.0 label Dec 26, 2020
@thomashoneyman
Copy link
Contributor

We may not be able to get this in for 0.14 due to a backlog of other work, so I'm going to remove the label. We can still do this as part of a subsequent set of breaking updates to the web organization updating some of these modules.

@JordanMartinez JordanMartinez added purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump. labels Dec 7, 2021
@JordanMartinez
Copy link
Contributor

To fix this, do we just need to change the argument here from HTMLElement to Element?

@natefaubion
Copy link
Author

It probably should not be in the HTMLElement module, but rather Element.

This was referenced Mar 25, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@natefaubion @JordanMartinez @thomashoneyman