Skip to content

Duplication with Web.DOM.Element #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
milesfrain opened this issue Aug 13, 2020 · 4 comments · Fixed by #74
Closed

Duplication with Web.DOM.Element #36

milesfrain opened this issue Aug 13, 2020 · 4 comments · Fixed by #74
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.

Comments

@milesfrain
Copy link
Contributor

It appears that Web.HTML.HTMLElement.setClassName is unnecessary when we have Web.DOM.Element.setClassName.

I haven't checked if there are other duplicated functions.

Loosely related to #29

@thomashoneyman thomashoneyman added the purs-0.14 A reminder to address this issue or merge this PR before we release PureScript v0.14.0 label Dec 10, 2020
@thomashoneyman
Copy link
Contributor

thomashoneyman commented Dec 10, 2020

I think this is reasonable to implement as part of the 0.14 changes, as well as other functions which really ought to live in Web.DOM (see #10 as well).

@milesfrain
Copy link
Contributor Author

Any suggestions on a good plan of attack for this issue?

Thinking the first step should be to find all the duplicates. Could start with a simple search for duplicated function names across libraries. Could get more advanced by searching for duplicate type signatures (with necessary substitutions, e.g. Element vs HTMLElement).

Should probably include deprecation warnings too.

@garyb
Copy link
Member

garyb commented Dec 17, 2020

I imagine looking at what the module exports compared with the IDL in the spec is probably the "safest" way of doing it. Plus we could make a note of anything that is missing at the same time.

As with all these libraries it's just a tedious and rather error-prone manual slog 🙁

@thomashoneyman
Copy link
Contributor

We may not be able to get this in for 0.14 due to a backlog of other work, so I'm going to remove the label. We can still do this as part of a subsequent set of breaking updates to the web organization updating some of these modules.

@thomashoneyman thomashoneyman removed the purs-0.14 A reminder to address this issue or merge this PR before we release PureScript v0.14.0 label Dec 26, 2020
@JordanMartinez JordanMartinez added purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump. labels Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants