Add the typeclass IsSendable #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JordanMartinez |
| @@ -21,8 +24,24 @@ instance IsSendable Char | |||
| instance IsSendable String | |||
| instance IsSendable a => IsSendable (Array a) | |||
| instance (RowToList r rl, IsSendableRowList rl) => IsSendable (Record r) | |||
| instance IsSendable Unit | |||
| instance IsSendable Void | |||
There was a problem hiding this comment.
Can you clarify why you added an instance for Void? I'm not sure that's correct, but I'm not sure about that either.
| @@ -21,8 +24,24 @@ instance IsSendable Char | |||
| instance IsSendable String | |||
| instance IsSendable a => IsSendable (Array a) | |||
| instance (RowToList r rl, IsSendableRowList rl) => IsSendable (Record r) | |||
| instance IsSendable Unit | |||
There was a problem hiding this comment.
Why is there an instance for Unit? Can you clarify?
There was a problem hiding this comment.
Actually, this instance and the instance for Void comes from the library workerbees but I can remove them if you want.
There was a problem hiding this comment.
Ah, ok. I think I missed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refers to the issue: #2
Add the typeclass IsSendable whose instances are Boolean, Int, Number, Char, String, Array, Record.
Change the signature of postMessage with
Prerequisites
purescript-webprojects. Although MDN is a great resource, it is not a suitable reference for this project.Description of the change
Clearly and concisely describe the purpose of the pull request. If this PR relates to an existing issue or change proposal, please link to it. Include any other background context that would help reviewers understand the motivation for this PR.
Checklist: