Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fromFormElement #15

Merged

Conversation

toastal
Copy link
Contributor

@toastal toastal commented Jan 22, 2021

Description of the change

https://xhr.spec.whatwg.org/#dom-formdata

It's really annoying not having a way to get FormData for Affjax despite having an HTMLFormElement.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@toastal toastal force-pushed the from-html-form-element branch from 327bdc7 to 41a9253 Compare January 23, 2021 02:42
@garyb
Copy link
Member

garyb commented Jan 23, 2021

It kinda sucks that we need to add a dependency on -html for this. 😞 I guess there isn't really another option though if we're being consistent with where things live.

@toastal
Copy link
Contributor Author

toastal commented Jan 25, 2021

@garyb , I mean I agree, but it already depends on web-dom and it wouldn't have a circular dependency issue. Not sure if this is best function name either.

@garyb
Copy link
Member

garyb commented Jan 25, 2021

Yeah, it makes sense, I was just lamenting the less than ideal situation! I meant to approve this 🙂.

@thomashoneyman thomashoneyman merged commit 145f362 into purescript-web:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants