Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding purescript-promises #273

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Conversation

mwalkerwells
Copy link
Contributor

Ran psc-package verify and everything checks 👌🏻

https://github.com/thimoteus/purescript-promises

@f-f
Copy link
Member

f-f commented Feb 28, 2019

Hi @mwalkerwells, thanks for the PR!

Since #271 the packages.json is not the main source of truth anymore, but it gets generated from the Dhall files. So in this case to make CI pass you should add the new package here

There were supposed to be instructions about this in the README, but it looks like something got lost in the refactoring, so they are now a bit unclear

@mwalkerwells
Copy link
Contributor Author

Ah, gotcha! I was following the instructions here: https://github.com/purescript/psc-package/blob/master/docs/maintenance.md

@f-f
Copy link
Member

f-f commented Feb 28, 2019

@mwalkerwells thanks for the heads up, I'll fix those docs too 🙂

@mwalkerwells
Copy link
Contributor Author

Need to wait for this to be accepted by @Thimoteus + have the package version bumped to v3.0.1

Thimoteus/purescript-promises#9

@f-f
Copy link
Member

f-f commented Feb 28, 2019

@mwalkerwells sounds good!
Note though that you'll need to commit also the changes to the packages.json (it should be enough to run make to get the new one now that you changed the Dhall files)

@mwalkerwells
Copy link
Contributor Author

Done 👌🏻

@mwalkerwells
Copy link
Contributor Author

@f-f Not getting a response, mind accepting this PR with my fork for now? I'll submit another PR once we fix his breaking build.

@f-f
Copy link
Member

f-f commented Mar 2, 2019

@mwalkerwells I'd prefer to include the upstream in the package-set if possible (also because we already include one of their packages), so let's wait some days, as the maintainer might be busy.

If you're using psc-package in the meanwhile you can point the tool at your fork of package-sets, by specifying the repo URL in the source key of your configuration

@mwalkerwells
Copy link
Contributor Author

Will do 👌🏻 Just reverted for now... We wait... 🙏🏻

@mwalkerwells mwalkerwells force-pushed the master branch 2 times, most recently from ddd142c to 8895d36 Compare March 6, 2019 07:25
@mwalkerwells
Copy link
Contributor Author

mwalkerwells commented Mar 6, 2019

@f-f PRs accepted & all should be good now

@justinwoo
Copy link
Collaborator

Thanks

@justinwoo justinwoo merged commit 17baecf into purescript:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants