-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API: sliding and slidingSizeStep #214
Comments
While the comment I made above discusses the design of the API, it does not ask whether the functionality should be added here. Does such |
Thanks for the writeup, @JordanMartinez. I come from scala and it has a very powerful collection library that's part of the standard-library. I missed this function for my side-project so I decided to write it in purescript ;-) see here. |
Ah... I forgot about the possibility of returning a lazy data structure. I'm wondering what the pros/cons of that would be. Personally, I'm not sure I'd want the Tuple version either. It also looks like the Iterator type is a mutable data structure that follows most OO patterns of that idea. A Zipper would be a corresponding counterpart for FP. |
I think it would be easier to implement functions like |
Backlinking to #212 for more context. The question here is whether to add
sliding
, a function that returns windows of the array, and what its type signature should be. A variation ofsliding
isslidingSizeStep
which allows one to control the size of the window and how far to step before creating a new window. We'll cover this function later in this issue.Starting with
sliding
, the core question is what the return type should be. Below, I'll refer to various ideas for implementations using_N
whereN
refers to the possible way forward._1 is what is proposed in #212. _2 is what Harry proposed in his comment, functioning more like a Zipper. _3 is something I am proposing for unifying the other two. For example, if we implemented _1 and _3 in this library, _2 could still easily be implemented via
(Tuple l r) -> {previous: Nothing, current: l, next: Just r}
.Since _2's zipper-like type might want additional features (e.g. a
Functor
instance) that is largely outside the scope of this project, I propose not implementing it as end-users can implement it and define their ownWindow
type. Moreover, _3 enables more potential use cases we cannot imagine right now (e.g.slidingF ((Tuple l r) -> l + r) [0, 1, 2, 3]
would produce[1, 3, 5]
), simulating ascanl
like feature.Let's move on to
slidingSizeStep
. If we ignore the size and step arguments in the function, the question arises again as to what the return type should be. Here's two factors that come to mind:Array _
orMaybe (NonEmptyArray _)
I believe _11 is to be preferred over _12 because one can still get
Foldable1
and friends without having to pay for theJust
constructor unwrapping in _12 by doing something like this:_13 provides the same zipper-like idea. However, it cannot be implemented because
arrays
does not depend onlists
. Working similar tosliding
, _4 provides an escape hatch to this problem. One could use _4 in combination with my own arrays-zipper to get an Array-based zipper or use pointed-list to get a List-based zipper.In conclusion, I propose we implement these four functions:
I'm not yet considering
rangeWithStep
that was also proposed in #212 because I want to first cover these two functions and their variations.The text was updated successfully, but these errors were encountered: