Skip to content

Add changelog entries since v5.3.1 #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 21, 2021
Merged

Add changelog entries since v5.3.1 #209

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6052fd1
Add changelog entries since v5.3.1
milesfrain Jan 18, 2021
84853b0
Further clustering of related changes
milesfrain Jan 18, 2021
7b0da80
Note 0.14 update
milesfrain Jan 18, 2021
75bd68b
fixups
milesfrain Jan 19, 2021
32b8f81
fixups2
milesfrain Jan 19, 2021
70dff3e
fixups3
milesfrain Jan 19, 2021
5702fb1
capitalization fixup
milesfrain Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,33 @@ Notable changes to this project are documented in this file. The format is based
## [Unreleased]

Breaking changes:
- Updated code for PureScript 0.14 (#181)
- Renamed `Data.Array.ST.empty` to `Data.Array.ST.new` (#191 #198)
- Renamed `group'` to `groupAll` (#194 #200)

New features:
- Added monomorphic `foldl` `foldr` `foldMap` `fold` `intercalate` to `Array` (#201)
- These are just wrapped versions from `Data.Foldable`
- Added monomorphic `foldl1` `foldr1` `foldMap1` `foldl1` `intercalate` to `Array.NonEmpty` (#201)
- These are just wrapped versions from `Data.Foldable`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure "wrapped versions" is the correct terminology here; @hdgarrood, do you have a suggestion?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think “wrapped” suggests that actually you’ve done something to them, whereas all we’ve done here is specialize. I’d suggest “specialized versions of the functions with the same names from Data.Foldable”. Is that true for all of these though? This shouldn’t be a separate bullet point either, it’s part of the same change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, the one I’m not sure about is intercalate - I thought it was supposed to get its own Array-specific implementation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn’t be a separate bullet point either, it’s part of the same change.

It's indented, to indicate a clarification rather than an entire new point, but I think it reads a little better as just sentences in the same bullet point and agree it should just merge into the previous line.

- Added monomorphic `elem` `notElem` `find` `findMap` `scanl` `scanr` `any` `all` (#189 #193 #201)
- Added `intersperse` `groupAllBy` `splitAt` (#179 #188 #194 #200 #201)
- Added `mapWithIndex` `groupBy` to `Array.NonEmpty` (#201 #164)

Bugfixes:
- Fixed `sort` so `undefined` is sorted by comparison function, and not simply moved to the end of the array (#195 #197)

Other improvements:
- Generated changelog and added PR template (#208, #209)
- Added benchmarking (#178)
- Migrated to GitHub Actions for CI (#187 #169)
- Removed some internal usages of `unsafeCoerce` (#184)
- Changed `foldM` type signature to more closely match `foldl` (#160)
- Updated installation instructions to use Spago (#171)
- Replaced foreign `cons` `snoc` `drop` `take` with purescript implementations (#180)
- Removed `return {}` from FFI function (#175)
- Bumped pulp version (#174)
- Removed primes from foreign modules exports (#168)

## [v5.3.1](https://github.com/purescript/purescript-arrays/releases/tag/v5.3.1) - 2019-10-13

Expand Down