Skip to content

change structure & add laws for enums #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2014

Conversation

jdegoes
Copy link
Contributor

@jdegoes jdegoes commented Oct 12, 2014

Review by @garyb.

@garyb
Copy link
Member

garyb commented Oct 12, 2014

Thanks, this module has needed some love since the start. It was only thrown in for DateTime originally so was never properly considered (and that module needs work as well now I think of it).

I guess it will be a little more effort to define an Enum instance now, but I think it will be worth it.

garyb added a commit that referenced this pull request Oct 12, 2014
change structure & add laws for enums
@garyb garyb merged commit 958f7fb into purescript:master Oct 12, 2014
@paf31
Copy link
Contributor

paf31 commented Oct 12, 2014

Looks good, thanks.

@paf31
Copy link
Contributor

paf31 commented Oct 12, 2014

This reminds me of something I had meant to bring up: I think it's good to start documenting things like this in comments, so that we can use docgen to render nice docs when it's ready. But what do you think of using markdown in comments to structure the documentation?

@garyb
Copy link
Member

garyb commented Oct 12, 2014

Sounds perfect to me, I already tend to write comments in that style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants