-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests and fix enumFromTo, closes #15 #16
Conversation
This PR actually depends on purescript/purescript#1963 as I'm using Eq and Ord deriving. This is why the build fails. |
Looks great, and thanks for adding the tests. I'll leave this open until we figure out what we're doing with getting the deriving changes included. |
Could you rebase this please? |
Rebased, but cannot get this working (neither on Travis, nor locally)... I need psc 0.9.0 in order to parse the Foldable.js FFI code, but pulp 8.2.1 does not work with psc 0.9.0... |
You have to either build Pulp 9 with psc 0.8.*, or use vanilla psc to build this, I think. |
No problem, I'll cherry-pick this and fix up anything else that is required. Thanks! |
Thanks for the hint. The tests pass locally if I build everything manually with psc 0.9.0. I cannot get Pulp master working (with both psc 0.9 and 0.8)... what is the right procedure to install Pulp manually? I tried following the steps in .travis.yml ... |
I had difficulty getting pulp to build from master too, I can't remember what I did to make it work in the end. I think there were dependency issues, perhaps a missing commit hash or something. @hdgarrood? |
Yeah, that sounds plausible. I think pulp should be updated to point at psvm master now, the PR it needed has been merged now IIRC. I can't get to a computer to address this until this weekend unfortunately. |
No need for me to do anything, checked out locally this builds and tests successfully. Thank you! |
I'm not sure if the changes to .travis.yml and package.json are fine...