Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder Inject instances to allow inj :: f ~> f #19

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Reorder Inject instances to allow inj :: f ~> f #19

merged 2 commits into from
Nov 30, 2018

Conversation

garyb
Copy link
Member

@garyb garyb commented Nov 30, 2018

Same as with the Either case 😉

@garyb garyb requested a review from hdgarrood November 30, 2018 13:15
@hdgarrood
Copy link
Contributor

Seems reasonable; presumably it would make sense to add a test too?

hdgarrood
hdgarrood approved these changes Nov 30, 2018
View reviewed changes
Copy link
Contributor

@hdgarrood hdgarrood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave it up to you re: tests

@garyb
Copy link
Member Author

garyb commented Nov 30, 2018

Thanks for checking!

@garyb garyb merged commit 96bcf8a into master Nov 30, 2018
@garyb garyb deleted the inj-reflexive branch November 30, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdgarrood hdgarrood hdgarrood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyb @hdgarrood