Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions #25

Merged
merged 4 commits into from
Dec 8, 2020
Merged

Migrate to GitHub Actions #25

merged 4 commits into from
Dec 8, 2020

Conversation

thomashoneyman
Copy link
Member

This PR migrates functors to use GitHub Actions instead of Travis for CI, as tracked for all core libraries in purescript/purescript#3962. It also updates the installation instructions to refer to Spago instead of Bower.

Copy link
Member

@kl0tl kl0tl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know why this builds without warning but there’s a MonadZero instance for App. Do you prefer to censor user defined warnings in this pull request or in another one, once we figured out why the warning isn’t emitted?

README.md Outdated
@@ -1,14 +1,14 @@
# purescript-functors

[![Latest release](http://img.shields.io/bower/v/purescript-functors.svg)](https://github.com/purescript/purescript-functors/releases)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most core libraries have a http://img.shields.io/github/release/purescript/purescript-xxx.svg badge, should we do the same here?

@kl0tl
Copy link
Member

kl0tl commented Dec 6, 2020

The warning is ignored because the MonadZero instance is newtype derived, I’ve opened purescript/purescript#3964 to track this issue. In the meantime we could declare a regular instance instead of newtype deriving it since there’s no members to implement but opening an issue to remember to remove the instance in the next major release of the compiler is probably enough.

@thomashoneyman thomashoneyman merged commit d17d036 into master Dec 8, 2020
@thomashoneyman thomashoneyman deleted the github-actions branch December 8, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants