Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to v0.14.0-rc3 #13

Closed
wants to merge 2 commits into from
Closed

Update to v0.14.0-rc3 #13

wants to merge 2 commits into from

Conversation

paluh
Copy link
Contributor

@paluh paluh commented Oct 14, 2020

@JordanMartinez
Copy link
Contributor

Even though CI builds here, it shouldn't be merged since globals will be deprecated.

@JordanMartinez
Copy link
Contributor

JordanMartinez commented Nov 12, 2020 •
edited
Loading

@paluh I believe the purescript/purescript-numbers#12 will be merged soon. Could you make the following changes? Once the numbers PR is merged, we can restart this PR's CI and it should build after that:

  • change the dependency from purescript-globals to purescript-numbers
  • in src/Performance/Minibench.purs, change import Global (infinity) to import Data.Number (infinity).

@JordanMartinez JordanMartinez mentioned this pull request Nov 13, 2020
Merged
@JordanMartinez
Copy link
Contributor

Superceded by #14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paluh @JordanMartinez