Update to v0.14.0-rc3 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind doing the globals port in a separate PR? The URI stuff shouldn’t be in here, and I think many of the functions already exported by this library cover the same needs as existing functions from globals so I don’t think we should reproduce those functions here. |
|
Sure |
hdgarrood
approved these changes
Oct 23, 2020
|
I've updated the PR to stop right before I started porting globals over. CI didn't pass because it was cancelled due to pushing a new commit soon thereafter. I don't see the "restart build" button so I can't restart it. |
|
Thanks! |
|
Try pushing an empty commit? |
|
It built this time, but says "Entry point (Test.Main) not found". Not sure why since its very clearly there. |
|
This is a bug in pulp, try updating pulp to the newest version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backlinking to purescript/purescript#3942