Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add Semigroup/Monoid Map instances with Warn #54

Merged
merged 4 commits into from
Mar 23, 2022
Merged

Re-add Semigroup/Monoid Map instances with Warn #54

merged 4 commits into from
Mar 23, 2022

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Addresses #36

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez
Copy link
Contributor Author

🏓 @thomashoneyman

We might want to get more feedback on this before merging.

@thomashoneyman
Copy link
Member

Want to copy/paste that last comment over to Discourse?

@JordanMartinez
Copy link
Contributor Author

Sure. I've copied it over there.

thomashoneyman
thomashoneyman approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@thomashoneyman thomashoneyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, but we should leave this for another week to see if anyone has a comment wrt the warnings.

@JordanMartinez
Copy link
Contributor Author

This PR will have been open for a week as of tomorrow (Wednesday). Since there's been no objection to dropping the Warn instance on SemigroupMap's instances, is this ready to be merged?

@thomashoneyman thomashoneyman merged commit 75b9bf4 into purescript:master Mar 23, 2022
@JordanMartinez JordanMartinez deleted the re-add-map-instances branch March 23, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordanMartinez @thomashoneyman