Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix difference #68

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Fix difference #68

merged 2 commits into from
Aug 30, 2023

Conversation

natefaubion
Copy link
Contributor

@natefaubion natefaubion commented Aug 30, 2023

Description of the change

Fixes Map.Internal.difference. Fixes #67.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

Comment on lines +255 to +256
if M.size d == 0 then
and (map (\k -> M.member k m2) (A.fromFoldable $ M.keys m1))
Copy link
Contributor Author

@natefaubion natefaubion Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added an extra predicate to the test for when d is empty.

@JordanMartinez JordanMartinez merged commit db50eee into master Aug 30, 2023
@JordanMartinez JordanMartinez deleted the nf/fix-difference branch August 30, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sets difference calculation is broken.
2 participants